From 235d8c304d5ec684f06c0c33c42bf421196712f6 Mon Sep 17 00:00:00 2001 From: Hyperling Date: Sun, 31 Jan 2021 17:21:39 -0600 Subject: [PATCH] Removing TODOs and fixing some consistency errors. --- facts/package.yml | 3 +-- facts/service.yml | 1 - facts/system.yml | 1 + tasks/cron.yml | 2 ++ tasks/flatpaks.yml | 2 ++ tasks/freebsd_gui.yml | 2 ++ tasks/harden.yml | 2 ++ tasks/hardness_check_lynis.yml | 2 ++ tasks/packages.yml | 2 ++ tasks/users.yml | 8 +------- 10 files changed, 15 insertions(+), 10 deletions(-) diff --git a/facts/package.yml b/facts/package.yml index 61b7b83..5881115 100644 --- a/facts/package.yml +++ b/facts/package.yml @@ -10,8 +10,7 @@ when: ansible_distribution == "Pop!_OS" -# TODO Needs tested -- name: Set Debian and Ubuntu Package Names +- name: Set Debian and Ubuntu Package Names set_fact: firefox: firefox-esr thunderbird: thunderbird diff --git a/facts/service.yml b/facts/service.yml index da8e5ef..c4fe907 100644 --- a/facts/service.yml +++ b/facts/service.yml @@ -10,7 +10,6 @@ when: ansible_distribution == "Pop!_OS" -# TODO Needs tested - name: Set Debian and Ubuntu Service Names set_fact: cups: cups diff --git a/facts/system.yml b/facts/system.yml index 0b8dc62..37b9a9e 100644 --- a/facts/system.yml +++ b/facts/system.yml @@ -1,3 +1,4 @@ +--- # Define file, folder, and other facts per OS. - name: Set Pop OS Facts diff --git a/tasks/cron.yml b/tasks/cron.yml index 9dfeebc..44b3d5d 100644 --- a/tasks/cron.yml +++ b/tasks/cron.yml @@ -1,3 +1,5 @@ +--- + - name: install cron job (ansible-pull) cron: user: ansible diff --git a/tasks/flatpaks.yml b/tasks/flatpaks.yml index d74a78f..b5040ca 100644 --- a/tasks/flatpaks.yml +++ b/tasks/flatpaks.yml @@ -1,3 +1,5 @@ +--- + # Pre-reqs - name: Install Flatpak package: diff --git a/tasks/freebsd_gui.yml b/tasks/freebsd_gui.yml index 05e3cb1..d6dcb89 100644 --- a/tasks/freebsd_gui.yml +++ b/tasks/freebsd_gui.yml @@ -1,3 +1,5 @@ +--- + - name: Install FreeBSD UI Software package: name: diff --git a/tasks/harden.yml b/tasks/harden.yml index 050186a..46d147f 100644 --- a/tasks/harden.yml +++ b/tasks/harden.yml @@ -1,3 +1,5 @@ +--- + - name: Remove CUPS Daemon service: name: "{{ cups }}" diff --git a/tasks/hardness_check_lynis.yml b/tasks/hardness_check_lynis.yml index 7871184..d6610d5 100644 --- a/tasks/hardness_check_lynis.yml +++ b/tasks/hardness_check_lynis.yml @@ -1,3 +1,5 @@ +--- + - name: Install Lynis git: repo: https://github.com/CISOfy/lynis diff --git a/tasks/packages.yml b/tasks/packages.yml index 96527f5..b4e8112 100644 --- a/tasks/packages.yml +++ b/tasks/packages.yml @@ -1,3 +1,5 @@ +--- + - name: Install Repo Software package: name: diff --git a/tasks/users.yml b/tasks/users.yml index d959c93..2401f6c 100644 --- a/tasks/users.yml +++ b/tasks/users.yml @@ -1,10 +1,4 @@ -# TODO This does not work in FreeBSD yet. -#TASK [Create Ansible User] ***************************************************** -#fatal: [freeboy]: FAILED! => {"changed": false, "msg": "pw: the password db file is busy\n", "name": "hyper", "rc": 1} -#changed: [localhost] -# -#TASK [Add Ansible Sudoers File] ************************************************ -#fatal: [localhost]: FAILED! => {"changed": false, "checksum": "154cc146010b36e25502dfe9a7f6b09fec8bbf43", "msg": "Destination directory /etc/sudoers.d does not exist"} +--- - name: Create Ansible User user: