From 39b949517a4d16794f24a77213b925ec55dd2e0f Mon Sep 17 00:00:00 2001
From: Hyperling <me@hyperling.com>
Date: Mon, 5 Oct 2026 07:13:36 -0700
Subject: [PATCH] android, fix everything lint suggested besides the pipefails
 for single liners.

---
 tasks/workstation/linux/software/android.yml | 62 ++++++++++++--------
 1 file changed, 37 insertions(+), 25 deletions(-)

diff --git a/tasks/workstation/linux/software/android.yml b/tasks/workstation/linux/software/android.yml
index 2fe80f8..264b785 100644
--- a/tasks/workstation/linux/software/android.yml
+++ b/tasks/workstation/linux/software/android.yml
@@ -205,29 +205,29 @@
 - name: Workstation | Linux | Software | Android | SDK
   block:
 
-  - name: Workstation | Linux | Software | Android | Download Commandline Tools
-    get_url:
-      url: "{{ android_url }}"
-      dest: "{{ android_download_file }}"
-      owner: "{{ user }}"
-      group: "{{ user }}"
-      mode: '0664'
-    when: not android_download_stat.stat.exists
+    - name: Workstation | Linux | Software | Android | Download Commandline Tools
+      ansible.builtin.get_url:
+        url: "{{ android_url }}"
+        dest: "{{ android_download_file }}"
+        owner: "{{ user }}"
+        group: "{{ user }}"
+        mode: '0664'
+      when: not android_download_stat.stat.exists
 
-  - name: Workstation | Linux | Software | Android | Create Folder
-    ansible.builtin.file:
-      path: "{{ android_sdk_cmdline_temp }}"
-      state: directory
-      owner: "{{ user }}"
-      group: "{{ user }}"
-      mode: '0755'
+    - name: Workstation | Linux | Software | Android | Create Folder
+      ansible.builtin.file:
+        path: "{{ android_sdk_cmdline_temp }}"
+        state: directory
+        owner: "{{ user }}"
+        group: "{{ user }}"
+        mode: '0755'
 
-  - name: Workstation | Linux | Software | Android | Extract Tools
-    unarchive:
-      src: "{{ android_download_file }}"
-      dest: "{{ android_sdk_cmdline_temp }}"
-      owner: "{{ user }}"
-      group: "{{ user }}"
+    - name: Workstation | Linux | Software | Android | Extract Tools
+      ansible.builtin.unarchive:
+        src: "{{ android_download_file }}"
+        dest: "{{ android_sdk_cmdline_temp }}"
+        owner: "{{ user }}"
+        group: "{{ user }}"
 
   become: true
   become_user: "{{ user }}"
@@ -251,6 +251,8 @@
     - emulator
   become: true
   become_user: "{{ user }}"
+  register: shell_check
+  changed_when: shell_check.rc == 0
   when: coding
     and not android_sdkmanager_check.stat.exists
 
@@ -345,6 +347,8 @@
   ansible.builtin.shell: "{{ android_sdkmanager2_list }} --all > {{ android_report_file }}"
   become: true
   become_user: "{{ user }}"
+  register: shell_check
+  changed_when: shell_check.rc == 0
   when: coding
 
 ## Flutter and Licenses ##
@@ -353,18 +357,24 @@
   ansible.builtin.shell: "{{ flutter }} config --android-sdk={{ android_sdk_location }}"
   become: true
   become_user: "{{ user }}"
+  register: shell_check
+  changed_when: shell_check.rc == 0
   when: coding
 
 - name: Workstation | Linux | Software | Android | License Agreements [1/2]
   ansible.builtin.shell: "yes | {{ android_sdkmanager_final }} --licenses --sdk_root={{ android_sdk_location }}"
   become: true
   become_user: "{{ user }}"
+  register: shell_check
+  changed_when: shell_check.rc == 0
   when: coding
 
 - name: Workstation | Linux | Software | Android | License Agreements [2/2]
   ansible.builtin.shell: "yes | {{ flutter }} doctor --android-licenses"
   become: true
   become_user: "{{ user }}"
+  register: shell_check
+  changed_when: shell_check.rc == 0
   when: coding
 
 - name: Workstation | Linux | Software | Android | Refresh Flutter Doctor Report
@@ -372,6 +382,8 @@
   loop: "{{ flutter_report_commands }}"
   become: true
   become_user: "{{ user }}"
+  register: shell_check
+  changed_when: shell_check.rc == 0
   when: coding
 
 ## Configure Environment ##
@@ -385,10 +397,10 @@
     state: absent
     create: true
     backup: true
+    mode: "0755"
   loop:
     - "{{ user_root.home }}"
     - "{{ user_user.home }}"
-  ignore_errors: true
   when: coding
     and user_root.home != ""
     and user_user.home != ""
@@ -402,10 +414,10 @@
     state: absent
     create: true
     backup: true
+    mode: "0755"
   loop:
     - "{{ user_root.home }}"
     - "{{ user_user.home }}"
-  ignore_errors: true
   when: coding
     and user_root.home != ""
     and user_user.home != ""
@@ -415,16 +427,16 @@
     path: "{{ user_user.home }}/{{ item }}"
     block: |
       export ANDROID_HOME="{{ android_sdk_location }}"
-      export ANDROID_SDK_ROOT="$ANDROID_HOME"  
+      export ANDROID_SDK_ROOT="$ANDROID_HOME"
       export PATH="$PATH:{{ android_bin_location }}:{{ android_sdk_cmdline_final }}"
     marker: '# {mark} MANAGED BY ANSIBLE | Android'
     state: present
     create: true
     backup: true
+    mode: "0755"
   loop:
     - ".bash_profile"
     - ".zprofile"
-  ignore_errors: true
   when: coding
     and user_user.home != ""