Hosts Variable Refactor, User Name Refactor, Metasploit, Brave on Fedora, Aliases (#19)

* Add Brave to Fedora (DNF).

* First attempt to add metasploit installer.

* Fix check for Linux and macOS to use System, not Distro.

* Add more memorable aliases for msfconsole.

* Telegraf is attemping to install doube-time since hosts match both localhost and hostname.

* Add missing pipe.

* Attempt to fix flatpak play no longer being able to find user_ling var. Don't see anything in the dev branch which would have changed this behavior though.

* Add note for future removal.

* Use general gather for all groups. Move user variables to it.

* Feodra Workstation succeeds now! Add newline to end of file.

* First attempt at doing host variables via local files.

* Try using ini as lookup.

* Remove "-" typo.

* Add an initial gather even though it may not have all values properly populated on a machine's first run.

* Fix typo in ignore.

* Try default values.

* Try defaults without quotes.

* Add a section header. Add a default back.

* Rename section to global.

* Add workstation provision file. Change variables to require true. Only load config file if hosts is not being used.

* Put flags back on Dell so that programs are not removed while configuring files.

* Add provision config read to workstation.

* Go ahead and force config files for hosts. Only affects dev branch until PR. Start making miner and server files.

* Change {{}} to (()) in comments to avoid undefined variable error.

* Attempt to modify existing task groups instead of moving all tasks to one large group.

* Try to use blocks.

* Name blocks and remove redundant calls.

* Do the bare minimum for miner and server so the variables are at least defined.

* Ensure Server and Miner look at their own files.

* Test how block variables are handled.

* Are the variables true Booleans, not strings??

* Change exits to tests so we can see which ones work.

* Add more tests.

* Add the test results.

* Add config_dir for plays to use when making any config files.

* Move provision config dir.

* Add results of test.

* Remove the exit. Fix the blocks' whens.

* Do provision after starting, that way all facts exist.

* Fix all "true"'s.

* Adjust variable checks for provision_config changes.

* Change gui to wrk. Add aliases to cat files.

* Comment entire hosts file.

* Add localhost,

* Try localhost rather than host file group.

* Fix typo in "prov_dir".

* Add newline to end of file.

* Add newline to end of file.

* Add newline to end of file.

* Debug variable. Should be getting set but receiving errors on Fedora.

* Add newline to end of file.

* Fix debug property, var not name.

* Fix show-config. Change show-config-all to only hit active files, not backups.

* Uncomment commented workstation.

* Add commands to edit files.

* Attempt to fix gitlab installer variables.

* Attempt to fix gitlab play variable.

* Replacing `ling` for `{{ user }}`.

* Remove TODO.

* Remove `config_dir` and move provision config back near top.

* `user_root` is not needed, already moved to /usr/local/etc/.

* Add value for running anything at all. This allows user to set up files before first run.

* Reduce the check frequency,

* Ensure files are printed in correct order. Also add a newline between each.

* Only send file if it exists, and then remove it if it sends successfully.

* Always set the destination variables.

* Only run the scp for systems without sshfs. Forgot that system variables were shared between the two, and do not want to scp the files to themselves then delete the files from the mount.

tasks/workstation/linux/software/flatpaks.yml

@@ -27,7 +27,7 @@
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Variables
   set_fact:
-    flatpak_exec_dir: "{{ user_ling.home }}/bin"
+    flatpak_exec_dir: "{{ user_user.home }}/bin"
     flatpak_exec: "flatpak run"
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Arrays
@@ -83,7 +83,7 @@
     state: present
     create: yes
   loop: "{{ flatpaks_generic }}"
-  become_user: ling
+  become_user: "{{ user }}"
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Generic | Executable Permissions
   file: 
@@ -101,7 +101,7 @@
     state: present
   loop: "{{ flatpaks_coding }}"
   ignore_errors: yes
-  when: coding is defined
+  when: coding == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Coding | Executables
   blockinfile:
@@ -114,8 +114,8 @@
     state: present
     create: yes
   loop: "{{ flatpaks_coding }}"
-  become_user: ling
-  when: coding is defined
+  become_user: "{{ user }}"
+  when: coding == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Coding | Executable Permissions
   file: 
@@ -123,7 +123,7 @@
     state: file
     mode: '0755'
   loop: "{{ flatpaks_coding }}"
-  when: coding is defined
+  when: coding == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Coding | Uninstall
   flatpak:
@@ -132,7 +132,7 @@
     state: absent
   loop: "{{ flatpaks_coding }}"
   ignore_errors: yes
-  when: coding is not defined
+  when: not coding == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Coding | Remove Executables
   file: 
@@ -140,7 +140,7 @@
     state: absent
   loop: "{{ flatpaks_coding }}"
   ignore_errors: yes
-  when: coding is not defined
+  when: not coding == true
 
 # Media Editors #
 
@@ -151,7 +151,7 @@
     state: present
   loop: "{{ flatpaks_editing }}"
   ignore_errors: yes
-  when: editing is defined
+  when: editing == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Audio/Video Editors | Executables
   blockinfile:
@@ -164,8 +164,8 @@
     state: present
     create: yes
   loop: "{{ flatpaks_editing }}"
-  become_user: ling
-  when: editing is defined
+  become_user: "{{ user }}"
+  when: editing == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Audio/Video Editors | Executable Permissions
   file: 
@@ -173,7 +173,7 @@
     state: file
     mode: '0755'
   loop: "{{ flatpaks_editing }}"
-  when: editing is defined
+  when: editing == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Audio/Video Editor Uninstalls
   flatpak:
@@ -182,7 +182,7 @@
     state: absent
   loop: "{{ flatpaks_editing }}"
   ignore_errors: yes
-  when: editing is not defined
+  when: not editing == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Audio/Video Editors | Remove Executables
   file: 
@@ -190,7 +190,7 @@
     state: absent
   loop: "{{ flatpaks_editing }}"
   ignore_errors: yes
-  when: editing is not defined
+  when: not editing == true
 
 # Gaming #
 
@@ -201,7 +201,7 @@
     state: present
   loop: "{{ flatpaks_gaming }}"
   ignore_errors: yes
-  when: gaming is defined
+  when: gaming == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Gaming | Executables
   blockinfile:
@@ -214,8 +214,8 @@
     state: present
     create: yes
   loop: "{{ flatpaks_gaming }}"
-  become_user: ling
-  when: gaming is defined
+  become_user: "{{ user }}"
+  when: gaming == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Gaming | Executable Permissions
   file: 
@@ -223,7 +223,7 @@
     state: file
     mode: '0755'
   loop: "{{ flatpaks_gaming }}"
-  when: gaming is defined
+  when: gaming == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Gaming | Uninstalls
   flatpak:
@@ -232,7 +232,7 @@
     state: absent
   loop: "{{ flatpaks_gaming }}"
   ignore_errors: yes
-  when: gaming is not defined
+  when: not gaming == true
 
 - name: Workstation | Linux | Flatpak Distro | Flatpak | Gaming | Remove Executables
   file: 
@@ -240,7 +240,7 @@
     state: absent
   loop: "{{ flatpaks_gaming }}"
   ignore_errors: yes
-  when: gaming is not defined
+  when: not gaming == true
 
 # Removals #
 
@@ -288,7 +288,7 @@
     repo: ppa:lutris-team/lutris
     update_cache: yes
     state: present
-  when: ansible_distribution == "Ubuntu" and gaming is defined
+  when: ansible_distribution == "Ubuntu" and gaming == true
   ignore_errors: yes
 
 - name: Workstation | Linux | Flatpak Distro | Package Manager | Add Lutris (besides ARM)
@@ -296,7 +296,7 @@
     name: 
       - lutris
     state: present
-  when: ansible_architecture != "aarch64" and gaming is defined
+  when: ansible_architecture != "aarch64" and gaming == true
   ignore_errors: yes
 
 - name: Workstation | Linux | Flatpak Distro | Package Manager | Remove Lutris (besides ARM)