From fc49d68d01957d8c3ab420f61daa2d248db7dfee Mon Sep 17 00:00:00 2001
From: Hyperling <me@hyperling.com>
Date: Sat, 19 Sep 2026 09:47:32 -0700
Subject: [PATCH] update, pacman, handle the noconfirm differently so that
 things like update-firmware still get the -y.

---
 facts/general/package.yml | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/facts/general/package.yml b/facts/general/package.yml
index c927683..135d8e3 100644
--- a/facts/general/package.yml
+++ b/facts/general/package.yml
@@ -101,11 +101,6 @@
     ansible_distribution_file: "{{ prov_dir }}/ansible_distribution.txt"
     ansible_pkg_mgr_file: "{{ prov_dir }}/ansible_pkg_mgr.txt"
 
-- name: General | Facts | Package | Update Command | Helpers | pacman
-  set_fact:
-    update_accept_var: '--noconfirm'
-  when: ansible_pkg_mgr == "pacman"
-
 - name: General | Facts | Package | Update Command | Store Variables
   shell: "{{ item }}"
   loop:
@@ -159,9 +154,9 @@
 
         pacman)
           echo "*** Pacman ***"
-          auto_accept=""
-          if [[ -n "$accept" ]]; then
-            auto_accept="{{ update_accept_var }}"
+          auto_accept="{{ update_accept_var }}"
+          if [[ "$auto_accept" == "-y" ]]; then
+            auto_accept="--noconfirm"
           fi
 
           sudo pacman -Syu $auto_accept ||