From bb08f1ef9415cd0d2c39685876040a7a49c166bd Mon Sep 17 00:00:00 2001
From: Hyperling <me@hyperling.com>
Date: Tue, 8 Sep 2026 08:24:30 -0700
Subject: [PATCH] pv-test, finish the function, still needs tested.

---
 rc_shared.sh | 60 +++++++++++++++++++++++++++++-----------------------
 1 file changed, 33 insertions(+), 27 deletions(-)

diff --git a/rc_shared.sh b/rc_shared.sh
index 2aa9dbc..54a5871 100644
--- a/rc_shared.sh
+++ b/rc_shared.sh
@@ -786,17 +786,16 @@ function pv-test {
 	fi
 
 	typeset -i size_in
-	size_in="$3"
-	if [[ -z $size_in ]]; then
+	read -p "What display ratio would you like to use? (720) " size_in
+	if [[ -z "$size_in" ]]; then
 		echo "Size not set, assuming 720."
 		size_in=720
 	fi
-	size="-filter:v scale=-1:$size_in"
 
 	typeset -u okay
-	echo " Testing with '$filename_in'"
-	echo " Normalize set to '$normalize'"
-	echo " Size set to '$size'"
+	echo "* Testing with '$filename_in'"
+	echo "* Normalize set to '$normalize'"
+	echo "* Size set to '$size'"
 	read -p "Look okay? (Y/n) " okay
 	if [[ "$okay" == "N" || "$okay" == "F"* ]]; then
 		echo "Not okay, aborting."
@@ -804,31 +803,38 @@ function pv-test {
 	fi
 
 	echo "libx264 libsvtav1 libx265" | while read vcodec; do
-		echo "3 4 5" | while read vpreset; do
-			echo "25 28 32" | while read crf; do
-				echo "aac opus" | while read acodec; do
-					echo "192k 128k" | while read abr; do
-						echo "mp4 mkv" | while read ext; do
-						newfile="_$vcodec-p$vpreset-$crf_$acodec-$abr.$ext"
-						start=$SECONDS
+		#echo "3 4 5" | while read vpreset; do
+			#echo "25 28 32" | while read crf; do
+				echo "1500k 2000k 2500k" | while read vbr; do
+					echo "aac opus" | while read acodec; do
+						echo "192k 128k" | while read abr; do
+							echo "mp4 mkv" | while read ext; do
+								#newfile="_$vcodec-p$vpreset-$crf_$acodec-$abr.$ext"
+								newfile="_$vcodec-$vbr_$acodec-$abr.$ext"
+								start=$SECONDS
 
-						ffmpeg -nostdin \
-							-i "$filename_in" \
-							$size \
-							-c:v $vcodec -preset $vpreset -crf $crf \
-							-c:a $audio -b:a $abr \
-							$normalize \
-							-movflags +faststart \
-							"$newfile"
+								# -preset $vpreset -crf $crf \
+								ffmpeg -nostdin \
+									-i "$filename_in" \
+									-filter:v scale=-1:$size_in \
+									-c:v $vcodec \
+									-b:v $vbr -minrate 0 -maxrate $vbr -bufsize $vbr \
+									-c:a $audio \
+									-b:a $abr \
+									$normalize \
+									-movflags +faststart \
+									"$newfile"
 
-						finish=$SECONDS
-						minutes=$(( (finish - start) / 60 ))
-						printf -v padded_mins "%03d" "$minutes"
-						mv $newfile "`fn`_${minutes}m$newfile"
+								finish=$SECONDS
+								minutes=$(( (finish - start) / 60 ))
+								printf "%03d" "$minutes" -v padded_mins
+								mv "$newfile" "`fn`_${minutes}m$newfile"
+							done
+						done
 					done
 				done
-			done
-		done
+			#done
+		#done
 	done
 }